Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash on Discovery #2206

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fix a crash on Discovery #2206

merged 4 commits into from
Sep 25, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 25, 2024 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes #

Fixes the crash by creating a header cell instead of dequeue a cell that is never used.

To test

  1. Start the app
  2. Open the Discovery section
  3. Tap on one of the feature headers that open another view
  4. Check that no crash happens and no warning for autoTranslateResizingConstraints show in the console.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the crash Crash related issues label Sep 25, 2024
@SergioEstevao SergioEstevao added this to the 7.73 ❄️ milestone Sep 25, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao changed the title Create a header cell instead of dequeue a cell that is never used. Fix a crash on Discovery Sep 25, 2024
danielebogo
danielebogo requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it doesn't crash. Just left one comment

@SergioEstevao SergioEstevao marked this pull request as ready for review September 25, 2024 12:34
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 25, 2024 12:35
@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.73 September 25, 2024 12:37
danielebogo
danielebogo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 6073d34 into release/7.73 Sep 25, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the fix_crash_in_discovery branch September 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
crash Crash related issues
Projects
None yet
Milestone
7.73
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @dangermattic @danielebogo