Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transcripts/decode html entities #2192

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Transcripts/decode html entities #2192

merged 4 commits into from
Sep 23, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 23, 2024 •
edited
Loading

| 📘 Part of: #1848 |
|:---:|

Fixes #

Update Transcripts for the html format to decode HTML entities

To test

  1. Start the app
  2. Open a podcast with Transcripts in the HTML format using html entities. Ex: https://pca.st/episode/1cb156bc-c05c-4e20-ada7-c3fb13c4d380
  3. Play an episode of the podcast
  4. Open the full screen player
  5. Tap on Transcripts
  6. Check if the transcript does not show any html entitities.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added [Type] Bug Used for issues where something is not functioning as intended. [Project] Transcripts labels Sep 23, 2024
@SergioEstevao SergioEstevao added this to the 7.73 ❄️ milestone Sep 23, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 23, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.73 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review September 23, 2024 12:34
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 23, 2024 12:34
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 23, 2024 12:34
danielebogo
danielebogo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked on that episode

Simulator Screenshot - iPhone 16 - 2024-09-23 at 14 31 01

@SergioEstevao SergioEstevao merged commit 5733acc into release/7.73 Sep 23, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the transcripts/decode_html_entities branch September 23, 2024 13:54
This was referenced Sep 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] Transcripts [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.73
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @dangermattic @danielebogo