Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on shelf actions #2174

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix crash on shelf actions #2174

merged 1 commit into from
Sep 18, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 17, 2024 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes this Sentry crash

This PR takes in account adjustment on row when selecting action

To test

  1. Start the app
  2. Start playing an episode
  3. Open the Full player
  4. Tap on the shelf actions [...] button
  5. Tap on Edit
  6. Move actions around
  7. Check if no crash happens

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added [Type] Bug Used for issues where something is not functioning as intended. crash Crash related issues labels Sep 17, 2024
@SergioEstevao SergioEstevao added this to the 7.73 ❄️ milestone Sep 17, 2024
@SergioEstevao SergioEstevao marked this pull request as ready for review September 17, 2024 22:28
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 17, 2024 22:28
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 17, 2024 22:28
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.73 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

danielebogo
danielebogo approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 63982e4 into release/7.73 Sep 18, 2024
7 of 9 checks passed
@SergioEstevao SergioEstevao deleted the fix/crash_on_shelf_actions branch September 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
crash Crash related issues [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.73
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @dangermattic @danielebogo