Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Episode sort setting on WatchOS #2172

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix: Episode sort setting on WatchOS #2172

merged 2 commits into from
Sep 16, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 16, 2024 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes #

This PR updates the old settings to have support for the new title sort options and also fixes the saving of the settings to respect the old settings on WatchOS.

To test

  • Start the app on WatchOS

  • Open the Source Watch

  • Open the Podcasts

  • Select a podcasts

  • Scroll up to see sort options

  • Choose the different options and see that the sorting is done correctly

  • Start the app on the iPhone

  • Open a Podcast

  • Tap on the ... button

  • Tap on sort options

  • Check that the sorting options shows correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Bug Used for issues where something is not functioning as intended. label Sep 16, 2024
@SergioEstevao SergioEstevao added this to the 7.73 ❄️ milestone Sep 16, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 16, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.73 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao changed the title Add older options for title sorting and ensure we still save with the… Fix: Episode sort setting on WatchOS Sep 16, 2024
@SergioEstevao SergioEstevao added the [Area] watchOS Issus related to watchOS label Sep 16, 2024
@SergioEstevao SergioEstevao marked this pull request as ready for review September 16, 2024 16:15
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 16, 2024 16:15
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 16, 2024 16:15
danielebogo
danielebogo approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

One thing, can you update the CHANGELOG with this fix?

@SergioEstevao SergioEstevao merged commit 66eb89b into release/7.73 Sep 16, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the fix_watch_option_2 branch September 16, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Area] watchOS Issus related to watchOS [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.73
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @dangermattic @danielebogo