-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 16: prepare to have betas using Xcode 16 beta #2078
Xcode 16: prepare to have betas using Xcode 16 beta #2078
Conversation
fastlane/Fastfile
Outdated
@@ -427,6 +427,11 @@ platform :ios do | |||
lane :finalize_release do |options| | |||
UI.user_error!('To finalize a hotfix, please use the finalize_hotfix_release lane instead') if ios_current_branch_is_hotfix | |||
|
|||
# Temporarily: we should remove after moving to Xcode 16 in definitive | |||
if !UI.confirm('Please ensure Xcode image is set to xcode-15.4 before moving forward, if it is, type y. If not, type n.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 | Style/NegatedIf: Favor unless over if for negative conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielebogo is that bot friend of yours? 🤣
@@ -427,6 +427,11 @@ platform :ios do | |||
lane :finalize_release do |options| | |||
UI.user_error!('To finalize a hotfix, please use the finalize_hotfix_release lane instead') if ios_current_branch_is_hotfix | |||
|
|||
# Temporarily: we should remove after moving to Xcode 16 in definitive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to automate this check so it's only really shown when we know the IMAGE_ID
is wrong?
# Temporarily: we should remove after moving to Xcode 16 in definitive | |
sh("grep 'IMAGE_ID: xcode-15.4' #{PROJECT_ROOT_FOLDER}/.buildkite/release-builds.yml", error_callback: ->(result) { | |
# Temporarily: we should remove after moving to Xcode 16 in definitive | |
unless UI.confirm('Please ensure Xcode image is set to xcode-15.4 before moving forward, if it is, type y. If not, type n.') | |
UI.user_error!('Before submitting the app to release please change the CI image to xcode-15.4') | |
end | |
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think that might be good
Although I pretend to remove all of that asap 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked good in testing. Left one small comment about whether we should automate the check for IMAGE_ID
so it isn't as easy to overlook. Not sure if that's worth the extra effort but thought I'd suggest it.
finalize_release
to ensure the image is set back to Xcode 15To test
bundle exec fastlane finalize_release
n
Also, CI must be 🟢.
Checklist
CHANGELOG.md
if necessary.