Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16: prepare to have betas using Xcode 16 beta #2078

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

leandroalonso
Copy link
Member

  • Changes the CI image to Xcode 16 beta
  • Add a question on finalize_release to ensure the image is set back to Xcode 15

To test

  1. Run bundle exec fastlane finalize_release
  2. When asked about the image type n
  3. ✅ fastlane should fail with "Before submitting the app to release please change the CI image to xcode-15.4"

Also, CI must be 🟢.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added this to the 7.71 ❄️ milestone Aug 21, 2024
@leandroalonso leandroalonso requested a review from a team as a code owner August 21, 2024 20:08
@leandroalonso leandroalonso requested review from bjtitus and removed request for a team August 21, 2024 20:08
@@ -427,6 +427,11 @@ platform :ios do
lane :finalize_release do |options|
UI.user_error!('To finalize a hotfix, please use the finalize_hotfix_release lane instead') if ios_current_branch_is_hotfix

# Temporarily: we should remove after moving to Xcode 16 in definitive
if !UI.confirm('Please ensure Xcode image is set to xcode-15.4 before moving forward, if it is, type y. If not, type n.')
Copy link
Collaborator

@dangermattic dangermattic Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Style/NegatedIf: Favor unless over if for negative conditions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielebogo is that bot friend of yours? 🤣

@dangermattic
Copy link
Collaborator

dangermattic commented Aug 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.71 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@@ -427,6 +427,11 @@ platform :ios do
lane :finalize_release do |options|
UI.user_error!('To finalize a hotfix, please use the finalize_hotfix_release lane instead') if ios_current_branch_is_hotfix

# Temporarily: we should remove after moving to Xcode 16 in definitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to automate this check so it's only really shown when we know the IMAGE_ID is wrong?

Suggested change
# Temporarily: we should remove after moving to Xcode 16 in definitive
sh("grep 'IMAGE_ID: xcode-15.4' #{PROJECT_ROOT_FOLDER}/.buildkite/release-builds.yml", error_callback: ->(result) {
# Temporarily: we should remove after moving to Xcode 16 in definitive
unless UI.confirm('Please ensure Xcode image is set to xcode-15.4 before moving forward, if it is, type y. If not, type n.')
UI.user_error!('Before submitting the app to release please change the CI image to xcode-15.4')
end
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think that might be good

Although I pretend to remove all of that asap 😆

Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good in testing. Left one small comment about whether we should automate the check for IMAGE_ID so it isn't as easy to overlook. Not sure if that's worth the extra effort but thought I'd suggest it.

@SergioEstevao SergioEstevao merged commit aa722b6 into release/7.71 Aug 22, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the xcode-16/prepare-for-xcode-16-in-betas branch August 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants