Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iPad crash on iOS18 and Xcode 16 #2077

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Aug 21, 2024

| 📘 Part of: # |
|:---:|

Fixes #2063

This PR avoid the crash resulting from the iPad Tab bar new design on iOS18 when using a TabViewController.

The way we are avoiding the crash is to force the TabBarController to believe is always in the compact mode and keep using the regular tab bar on the bottom.

I tried to adapt to the new design but there are several issues with our current design of the app:

  • Our mini-player is positioned above the tab bar ( this was reason for the crash because on the new design the tabbar is not in the same hierarchy as the mini-player)
  • Our animations for the mini-player assume the tabbar is on the bottom
  • The new tab bar design only allows to show 4 items on portrait mode and we currently 5 items so it show a chevron to display more options

To test

  • Using Xcode 16 beta 5 and an iOS 18 iPad device start the app
  • Ensure that the app does not crash at startup
  • Rotate the device and use the multiple split-view modes and check the app is working correctly
  • Test on iOS 18 iPhone device to see if the tab bar shows correctly
  • Repeat the tests on XCode 15.4 and iOS 17

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.71 ❄️ milestone Aug 21, 2024
@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.71 August 21, 2024 18:02
@SergioEstevao SergioEstevao marked this pull request as ready for review August 21, 2024 18:05
@SergioEstevao SergioEstevao requested a review from a team as a code owner August 21, 2024 18:05
@SergioEstevao SergioEstevao merged commit f18b522 into release/7.71 Aug 21, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the try/fix_ipad_tab_crash_on_iOS18 branch August 21, 2024 21:27
@pachlava pachlava added the [Type] Bug Used for issues where something is not functioning as intended. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] iOS 18 [Type] Bug Used for issues where something is not functioning as intended. Xcode Update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 18 -> TabController new TabBar design makes app crash
3 participants