Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the profile header view always returns a minimum size that is visible #2074

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

When testing the subscription purchase flows on the profile on the iPad, I noticed that the profile view disappeared when multi-task / split mode where activated.

The reason is that the ProfileHeaderView returns a size of zero and that make the profile view controller header size method to set a zero height for the header and the view never recovers that.

The fix will ensure that a minimum size is always returned.

To test

  • Start the app on a iPad
  • Go to Profile tab
  • Activate multitask mode on the iPad and split view with Safari for example
  • Check that on the different multitask modes the Account header is always visible

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Bug Used for issues where something is not functioning as intended. label Aug 21, 2024
@SergioEstevao SergioEstevao added this to the 7.71 ❄️ milestone Aug 21, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 21, 2024

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.71 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review August 21, 2024 15:08
@SergioEstevao SergioEstevao requested a review from a team as a code owner August 21, 2024 15:08
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team August 21, 2024 15:08
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified the issue on trunk
✅ Verified the Profile Header is now shown in split screen

@SergioEstevao SergioEstevao merged commit 86a5cc2 into release/7.71 Aug 22, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the fix_dissapearing_header_on_profile branch August 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants