Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fix cancel subscription URL #2070

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[Bug Fix] Fix cancel subscription URL #2070

merged 2 commits into from
Aug 20, 2024

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Aug 20, 2024 •
edited
Loading

Fixes the Cancel subscription URL

To test

  • Go to Profile -> Account -> Cancel Subscription
  • Tap on `Yes, Cancel my Subscription -> Show Me How
  • The webpage should load correctly
Before Now
Simulator Screenshot - iPhone 15 Pro - 2024-08-20 at 18 29 16 Simulator Screenshot - iPhone 15 Pro - 2024-08-20 at 18 39 34

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Bug Used for issues where something is not functioning as intended. label Aug 20, 2024
@danielebogo danielebogo added this to the 7.71 ❄️ milestone Aug 20, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@danielebogo danielebogo marked this pull request as ready for review August 20, 2024 17:46
@danielebogo danielebogo requested a review from a team as a code owner August 20, 2024 17:46
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team August 20, 2024 17:46
@danielebogo
Copy link
Contributor Author

Thanks @leandroalonso

@danielebogo danielebogo merged commit cd03f75 into release/7.71 Aug 20, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/fix-subscription-url branch August 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao SergioEstevao was automatically assigned from Automattic/pocket-casts-ios

Assignees
No one assigned
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.71
Development

Successfully merging this pull request may close these issues.
3 participants
@danielebogo @dangermattic @leandroalonso