Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handling /get/?args #1977

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

leandroalonso
Copy link
Member

In the latest newsletter we add a new type of /get link, eg.: https://pocketcasts.com/get/?utm_source=email.

The app doesn't handle /get/ though, which makes it to open the browser.

To test

  1. Run the app on a real device
  2. Add https://pocketcasts.com/get/?utm_source=email to the Notes app for example
  3. Tap on it
  4. ✅ The app should open and it should not open Safari
  5. Test https://pocketcasts.com/get
  6. ✅ It should open the app

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Type] Bug Used for issues where something is not functioning as intended. label Aug 1, 2024
@leandroalonso leandroalonso added this to the 7.69 ❄️ milestone Aug 1, 2024
@leandroalonso leandroalonso requested a review from a team as a code owner August 1, 2024 17:53
@leandroalonso leandroalonso requested review from danielebogo and removed request for a team August 1, 2024 17:53
@leandroalonso leandroalonso changed the title Fix: handling /get/?args Fix: handling /get/?args Aug 1, 2024
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leandroalonso leandroalonso merged commit da1e888 into release/7.69 Aug 1, 2024
4 of 6 checks passed
@leandroalonso leandroalonso deleted the fix/get-with-arguments branch August 1, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended. [Type] Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants