Add new Medium "Now Playing" widget #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielebogo
reviewed
Jul 8, 2024
Comment on lines
22
to
25
| if family == .systemSmall { | ||
| smallWidget(playingEpisode: playingEpisode) | ||
| } else { | ||
| mediumWidget(playingEpisode: playingEpisode) |
There was a problem hiding this comment.
Nit:
I would use a switch here when dealing with enums
|
Following the test instructions, it worked as described 👌 |
…y different content instead
jgcaruso
requested review from
bjtitus and
danielebogo
and removed request for
a team
danielebogo
reviewed
Aug 13, 2024
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| - A new button is added under Account Settings: "Change Avatar". It opens the in-app Safari with Gravatar's Avatar Quick Editor. [#1770](https://github.com/Automattic/pocket-casts-ios/pull/1770) | |||
| - Adds the ability to rate podcasts [#1879](https://github.com/Automattic/pocket-casts-ios/issues/1879) | |||
| - Improve the sort by name algorithm [#1959](https://github.com/Automattic/pocket-casts-ios/issues/1959) | |||
| - Adds a medium size for the Now Playing widget [#1876](https://github.com/Automattic/pocket-casts-ios/pull/1876) | |||
There was a problem hiding this comment.
Let's update this following the assigned milestone. For now I set it to 7.72
bjtitus
approved these changes
Aug 14, 2024
| .foregroundColor(widgetColorScheme.bottomTextColor.opacity(0.6)) | ||
| Spacer() | ||
| Image(widgetColorScheme.iconAssetName) | ||
| .frame(width: 28, height: 28) |
There was a problem hiding this comment.
⛏️ It seems like this icon size is used three times, could it be put into a Constants or some other local property?
There was a problem hiding this comment.
Good call. Wasn't sure where best to add it but I found a CommonWidgetHelper class to add the property to, and found all cases where widget icon frame was being defined (it was more than 3) and updated them all.
|
Pinging @david-gonzalez-a8c to give it some 👀 on the design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1343 that introduces the new medium Now Playing widget from Lkt7fuf9Nq3XvfAFPCfpTD-fi-995_4119
Also adapts the existing "nothing playing" view for the medium size.
iOS 17
iOS 16
Nothing Playing
To test
NOTE: I'm not entirely sure when
showsWidgetContainerBackgroundwill ever be false for these widgets, but if you want to simulate that you can setLine 8ofNowPlayingEntryView.swiftforcevar showsWidgetBackground = falseand then see how it renders. It won't be pretty because padding is removed for some reason, but that isn't done as part of this PR.Checklist
CHANGELOG.mdif necessary.