Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: fix an issue when showing episodes #1874

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Search: fix an issue when showing episodes #1874

merged 3 commits into from
Jul 4, 2024

Conversation

leandroalonso
Copy link
Member

When a user performs a search and taps on an unavailable episode we load and display it through EpisodeLoadingController.

In a recent ticket a user informs us that the swipe down to dismiss is not working in this part, this PR fixes it by changing how the EpisodeDetailViewController is presented.

To test

  1. Do a clean install
  2. Go to discover
  3. Search for any term
  4. Tap on an episode
  5. Swipe down
  6. ✅ View should dismiss
  7. Tap on another episode from another podcast
  8. ✅ Ensure all buttons are working correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Type] Bug Used for issues where something is not functioning as intended. label Jul 1, 2024
@leandroalonso leandroalonso added this to the 7.68 milestone Jul 1, 2024
@leandroalonso leandroalonso requested a review from a team as a code owner July 1, 2024 15:32
@leandroalonso leandroalonso requested review from bjtitus and removed request for a team July 1, 2024 15:32
bjtitus
bjtitus approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified Swipe down
✅ Verified buttons work

@leandroalonso leandroalonso enabled auto-merge July 4, 2024 15:48
@leandroalonso leandroalonso merged commit b7f2c91 into trunk Jul 4, 2024
4 of 6 checks passed
@leandroalonso leandroalonso deleted the fix/scroll-down-to-dismiss-episode-search branch July 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjtitus bjtitus bjtitus approved these changes

Assignees
No one assigned
Labels
Search Improvements [Type] Bug Used for issues where something is not functioning as intended. [Type] Fix
Projects
None yet
Milestone
7.68
Development

Successfully merging this pull request may close these issues.
3 participants
@leandroalonso @bjtitus @pachlava