Update lint dev-dependencies #15172
Merged
Update lint dev-dependencies #15172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks 👍
I have been looking to upgrade to ESLint 9, I think it is fine for Mongoose 8 to use that even with the Node 18+ requirement, because lint success/failure shouldn't depend on Node version. However, ESLint 9 has completely new configuration format, which has made upgrading tricky in my experience, so I haven't started that yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates some lint dev-dependencies to their latest version. ESLint 8.x is EOL, so we might as well use the latest version.
Should we upgrade ESLint to 9.x within mongoose 8.x (which requires node 18+), as we only run lint in higher node environments and also already have other things that require higher node versions?