Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change all symbols to use a consistent name #13641

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: change all symbols to use a consistent name #13641

merged 1 commit into from
Jul 25, 2023

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR changes all Symbol-strings to be consistently named

  • replacing . and : with #
  • adding mongoose# where it was not previously

i have made this against the 8.0 branch, because this may not affect others, but still some change

@hasezoey hasezoey added the developer-experience This issue improves error messages, debugging, or reporting label Jul 21, 2023
@hasezoey hasezoey added this to the 8.0 milestone Jul 21, 2023
@hasezoey hasezoey requested a review from vkarpov15 July 21, 2023 13:22
vkarpov15
vkarpov15 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit cdad34b into Automattic:8.0 Jul 25, 2023
@hasezoey hasezoey deleted the 8consistentSymbol branch July 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
developer-experience This issue improves error messages, debugging, or reporting
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hasezoey @vkarpov15