refactor(model): allow optionally passing indexes to createIndexes and cleanIndexes #12280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exist on mongodb server re #12250
AbdelrahmanHafez
changed the title
AbdelrahmanHafez
requested review from
vkarpov15,
IslandRhythms and
Uzlopak
and removed request for
vkarpov15
| @@ -6756,6 +6755,31 @@ describe('Model', function() { | |||
| ); | |||
|
|
|||
| }); | |||
| xit('creates indexes only when they do not exist on the mongodb server (gh-12250)', async() => { | |||
There was a problem hiding this comment.
This is marked as pending because this is not fixed yet, the PR was initially meant to fix the issue, but it's taking longer than anticipated. So for now let's stick to the refactoring, and I'll fix it later
AbdelrahmanHafez
changed the title
vkarpov15
reviewed
Aug 30, 2022
|
@vkarpov15 I remember one challenging part was understanding why What do you think? |
vkarpov15
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
diffIndexesto smaller functions.Also, refactors
cleanIndexesandcreateIndexesto accept receiving optional parameters for the indexes to drop/create. This reduces the number oflistIndexesrequired forsyncIndexesto work.I'd like to merge this since it's in a functional state, then I'll work on fixing #12250 once I can dedicate more time to it.