types: implement Schema.discriminator #11855
Conversation
|
Regarding your comment returning void. Actually by using discriminator we mutate the schema. Maybe it would ne better to actually instantiate a new Schema instance and apply the discriminator on it. Idk. Is it possible to type mutation in typescript? |
|
applied changes |
Uzlopak
changed the title
| Schema.prototype.discriminator = function(name, schema) { | ||
| this._applyDiscriminators = {}; | ||
| this._applyDiscriminators[name] = schema; | ||
| this._applyDiscriminators = Object.assign({}, this._applyDiscriminators, { [name]: schema }); |
There was a problem hiding this comment.
There's no need to create a new object every single time. Just Object.assign(this._applyDiscriminators, { [name]: schema }); should be enough.
There was a problem hiding this comment.
Unit Tests fail if i apply your Suggestion
There was a problem hiding this comment.
Can't see why. But I'll merge this and try it out for myself.
|
I've not used this before actually, but according to the docs or "JS-docs" the example shows that discriminator will return a model, and it is a model FN. |
| Schema.prototype.discriminator = function(name, schema) { | ||
| this._applyDiscriminators = {}; | ||
| this._applyDiscriminators[name] = schema; | ||
| this._applyDiscriminators = Object.assign({}, this._applyDiscriminators, { [name]: schema }); |
There was a problem hiding this comment.
Can't see why. But I'll merge this and try it out for myself.
Resolves #11837