Mark Mongoose 6 as compatible with MongoDB 4 #11320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * MongoDB Server 4.0.x: mongoose `^5.2.0` | ||
| * MongoDB Server 4.2.x: mongoose `^5.7.0` | ||
| * MongoDB Server 4.4.x: mongoose `^5.10.0` | ||
| * MongoDB Server 4.0.x: mongoose `^5.2.0` or `6.x` |
There was a problem hiding this comment.
AFAIK, we don't drop support for older MongoDB versions as we upgrade versions, so I assume it's safe to change this with:
Suggested change
| * MongoDB Server 4.0.x: mongoose `^5.2.0` or `6.x` | |
| * MongoDB Server 4.0.x: mongoose >= `^5.2.0` |
Correct me if I'm wrong @vkarpov15
There was a problem hiding this comment.
I think that ^5.2.0 or 6.x is less brittle, because otherwise what happens with Mongoose 7?
vkarpov15
approved these changes
Feb 7, 2022
| * MongoDB Server 4.0.x: mongoose `^5.2.0` | ||
| * MongoDB Server 4.2.x: mongoose `^5.7.0` | ||
| * MongoDB Server 4.4.x: mongoose `^5.10.0` | ||
| * MongoDB Server 4.0.x: mongoose `^5.2.0` or `6.x` |
There was a problem hiding this comment.
I think that ^5.2.0 or 6.x is less brittle, because otherwise what happens with Mongoose 7?
vkarpov15
added
the
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation in #11302, I assume Mongoose 6 is compatible with MongoDB 4. Update docs so people know that a safe upgrade is possible.