fix(index.d.ts) treat _id like other fields in $project

[rpenido]

Fix #11088
Fix #11099

Changed type to

$project: { _id?: 0 | false; [field: string]: any } | {_id: 1 | true}

✔️ OK

{
  $project: {
    _id: 1,
  }
}

✔️ OK

{
  $project: {
    _id: 0,
    someField: 1
  }
}

❌ Error

{
  $project: {
    _id: 1,
    someField: 1
  }
}

[Uzlopak]

_id can also be null and could be an issue if strictNullChecks is true.

[rpenido]

_id can also be null and could be an issue if strictNullChecks is true.

Both cases below also work because of the ? in _id? type declaration

{
  someField: 1
}

{
  _id: undefined,
  someField: 1
}

Was that your concern? Could you please clarify?

Thank you!

[Uzlopak]

You are right. This is not an issue. Good Work.

[intenser]

$project: { _id?: 0 | false; [field: string]: any } | {_id: 1 | true}

I'm not sure that is a correct definition. MongoDB allows a lot of variations for _id:

{$project:{_id: "some text"}}

{$project:{_id: "$referOtherField"}}

{$project:{_id: {$concat: ["$firstName", "$lastName"]}}} // expressions

Or even:

{ $project: {
    _id: {
      $cond: {
        if: { $eq: ['server', '$deviceType'] },
        then: '$$REMOVE',
        else: '$_id'
      }
    },
    deviceType: 1
}}

[rpenido]

I agree with you.

So I don't think that we should treat _id differently.

[tbhaxor]

This would work. Can we merge this and release it in next version

[vkarpov15]

Thanks 👍