-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: timestamps createdAt property immutable by default #10267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that such change is a breaking change and should not be included in a minor/patch release.
I think it's fine to set createdAt
to be immutable
by default, but if we choose to go that way, we need to move it to v6.0.
Also, would be neat to offer a global option to set createdAt
to false
for those who choose to.
@AbdelrahmanHafez you're right about this being potentially backwards breaking, I'll merge this into 6.0 just to be safe. Any ideas for syntax re: setting |
@vkarpov15 |
@AbdelrahmanHafez would having an immutable |
@vkarpov15 We can ship this as an option to set immutable globally on createdAt, to be false by default in v5, then change it to true by default in v6. |
So there is a failing test, however I'm not sure If the test needs to be fixed or my solution needs to be changed. The test is gh-9105