Document.populate & Document.execPopulate in a transaction

[sebastian-nowak]

Docs for doc.$session() only mention that it applies save():

Does it mean that calling doc.populate() or doc.execPopulate will ignore the associated mongo session?

[vkarpov15]

Yes it will, we missed that. Thanks for pointing out this issue, we will fix ASAP 👍

[vkarpov15]

Fixed in master, will be released in 5.2.6 next Monday 👍

[sebastian-nowak]

That's great, thank you @vkarpov15 🙂

Just noticed one thing:

     // Use `$session()` by default if the document has an associated session
     // See gh-6754
     if (this.$session() != null) {
       const session = this.$session();
       paths.forEach(path => {
         path.options = path.options || {};
         path.options.session = session;
       });
     }

It means that $session on a document takes precedence over session passed explicitly via options. Shouldn't it be the other way around?

[vkarpov15]

You're right, good catch, will fix 👍