Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing id setter #13784

Closed
2 tasks done
vkarpov15 opened this issue Aug 25, 2023 · 2 comments
Closed
2 tasks done

Consider removing id setter #13784

vkarpov15 opened this issue Aug 25, 2023 · 2 comments
Milestone
8.0

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

In 7.4, we made it so that doc.id = 'foo' is equivalent to doc._id = 'foo'. However, this has caused some trouble, like #13732, #13762, and some other issues. Perhaps we remove this change for 8.0?
@vkarpov15 vkarpov15 added this to the 8.0 milestone Aug 25, 2023
@IslandRhythms IslandRhythms mentioned this issue Sep 15, 2023
Merged
@vkarpov15 vkarpov15 reopened this Sep 15, 2023
@vkarpov15
Copy link
Collaborator Author

Note to self to remove #13854 as well

@vkarpov15
Copy link
Collaborator Author

Fixed by #13877

vkarpov15 added a commit that referenced this issue Sep 26, 2023
@vkarpov15
docs(migrating_to_8): add id setter change to migration guide
2348b7a 
Fix #13784
sagrawal31 referenced this issue Jul 30, 2024
@IslandRhythms
id setter virtual
32a84b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
1 participant
@vkarpov15