Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: avoid using mquery for updateX() #13617

Closed
2 tasks done
vkarpov15 opened this issue Jul 18, 2023 · 0 comments
Closed
2 tasks done

Refactor: avoid using mquery for updateX() #13617

vkarpov15 opened this issue Jul 18, 2023 · 0 comments
Milestone
8.0

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Right now all query functions bypass mquery, except for updateX() because of _update in query.js. That's an annoyingly inconsistent API because mquery relies on its own collection wrapper, which has a tendency to fall out of date with Mongoose's.

Once we change this, we should also see if we can remove mquery from Mongoose entirely.
@vkarpov15 vkarpov15 added this to the 8.0 milestone Jul 18, 2023
vkarpov15 added a commit that referenced this issue Aug 24, 2023
@vkarpov15
BREAKING CHANGE: stop using mquery for updateX(), deleteX(), `sor…
c833ee2 
…t()`, always convert sort args to objects

Re: #13617
@vkarpov15 vkarpov15 mentioned this issue Aug 24, 2023
Merged
vkarpov15 added a commit that referenced this issue Aug 25, 2023
@vkarpov15
Merge pull request #13777 from Automattic/vkarpov15/gh-13617
f4f69e3 
BREAKING CHANGE: stop using mquery for `updateX()`, `deleteX()`, `sort()`, always convert sort args to objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
1 participant
@vkarpov15