Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup amp support #9570

Merged
merged 4 commits into from
May 18, 2018
Merged

Cleanup amp support #9570

merged 4 commits into from
May 18, 2018

Conversation

gravityrail
Copy link
Contributor

Addresses non-critical feedback on #9458.

  • Newline at end of file
  • Move require of AMP support to 3rd-party.php
  • Fix some incorrect docblock version numbers
  • PHP style tweaks

@gravityrail gravityrail requested a review from a team as a code owner May 17, 2018 20:11
@gravityrail gravityrail requested review from jeherve and ebinnion May 17, 2018 20:11
@gravityrail gravityrail self-assigned this May 17, 2018
@gravityrail gravityrail added this to the 6.2 milestone May 17, 2018
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 17, 2018
ebinnion
ebinnion approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@ebinnion ebinnion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only nit I have is that I think the @since should be 6.2.0 instead of 6.2.

@gravityrail gravityrail merged commit 25e2c99 into master May 18, 2018
@gravityrail gravityrail deleted the fix/cleanup-amp-support branch May 18, 2018 14:54
@kraftbj kraftbj removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebinnion ebinnion ebinnion approved these changes

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@gravityrail gravityrail

Labels
General Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@gravityrail @ebinnion @kraftbj @jeherve @oskosk @matticbot