-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required-review: Add is-author-or-reviewer
condition
#41966
base: trunk
Are you sure you want to change the base?
Conversation
Sometimes people want to allow someone (or some team) to "self-review" code. GitHub doesn't support self-reviews directly, but we can assume that the author has reviewed their own PR in the writing of it. Also, this is well past needing some automated testing. Add some for the file being touched here. Fixes #41933
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage Summary7 files are newly checked for coverage. Only the first 5 are listed here.
Full summary · PHP report · JS report Add label
I don't care about code coverage for this PR
|
Too bad it only does five, it missed out on having this line 😀
|
Proposed changes:
Sometimes people want to allow someone (or some team) to "self-review" code. GitHub doesn't support self-reviews directly, but we can assume that the author has reviewed their own PR in the writing of it.
Also, this is well past needing some automated testing. Add some for the file being touched here.
Other information:
Jetpack product discussion
Fixes #41933
Does this pull request change what data or activity we track or use?
No
Testing instructions: