-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wpcomsh: bilmur: Add site timezone to tag #41964
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
c93b3c7
to
16b66b8
Compare
Tested on a WoA dev site:
|
Fixes #
Proposed changes:
wpcomsh_stats_timezone_string()
to standardize timezone output (e.g., converts+05:30
toAsia/Kolkata
orEtc/GMT+5
).data-site-tz
attribute in the Bilmur<script>
tag.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Yes, this PR adds the site’s timezone to the data sent to Bilmur for performance tracking. This could indirectly reveal location info (e.g.,
America/New_York
), but it’s site-level, not user-level data.Testing instructions:
<script id="bilmur" ...>
tag in the footer.data-site-tz
attribute (e.g.,data-site-tz="Etc/GMT+0"
or a city likeAsia/Kolkata
).UTC+5:30
orNew York
), reload, and verify thedata-site-tz
updates accordingly.