-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Improve critical css generation process #41946
base: trunk
Are you sure you want to change the base?
Boost: Improve critical css generation process #41946
Conversation
We need to do this, otherwise the library will generate css for the 404 page.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 7 files. Only the first 5 are listed here.
1 file is newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
1caa3a8
to
fa49239
Compare
This PR fixes the C.CSS generation process breaking when an invalid URL was passed to the critical CSS gen library.
Recommendations will also now be more unique instead of bunched together under one entry on the advanced recommendations page. Previously, if a provider failed and had URLs with a 301, 404 and 500 error, items would be listed under the 500 error (or the most frequent one). Now they all have separate recommendations and can be dismissed individually. In other words, the
error_status
for providers has been replaced withdismissed_errors
and now holds all error types that were dismissed via the UI.Fixes #41391
Proposed changes:
InvalidURLError
recommendation and steps on how to address it;Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
TBD