Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack E2E: Introduce Account Protection Tests #41835

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Feb 16, 2025

Proposed changes:

  • Adds Jetpack E2E tests to cover the account protection feature, with initial test for compromised password detection.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-scan-team/issues/1696

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • See the E2E README to run tests locally. You can use pnpm test:run ./specs/post-connection/account-protection.test.js with optional --headed param for a live browser preview of the tests exection, or --debug to step through tests with debug tools.
  • Alternatively, you can review the logs from the automated test run on this PR.

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Feb 16, 2025
@nateweller nateweller self-assigned this Feb 16, 2025
@nateweller nateweller requested a review from a team February 16, 2025 20:31
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/account-protection-e2e branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/account-protection-e2e
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests E2E Tests labels Feb 16, 2025
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Feb 16, 2025

Code Coverage Summary

No summary data is avilable for parent commit 05491e7, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 05491e7 is available.

Full summary · PHP report · JS report

@nateweller nateweller force-pushed the add/account-protection-e2e branch 6 times, most recently from b70976c to b69464d Compare February 17, 2025 18:07
@nateweller nateweller force-pushed the add/account-protection-e2e branch 12 times, most recently from 6e7e362 to c49c641 Compare February 18, 2025 23:10
@nateweller
Copy link
Contributor Author

No changelog on account protection as it is merging into the add/account-protection branch.

@nateweller nateweller force-pushed the add/account-protection-e2e branch from d290b16 to 187a8f6 Compare February 19, 2025 00:03
@nateweller nateweller marked this pull request as ready for review February 19, 2025 00:06
@nateweller nateweller added [Status] Needs Team Review Your teammate needs to review this PR. and removed [Status] In Progress labels Feb 19, 2025
@nateweller nateweller changed the title Jetpack E2E: Account Protection Tests Jetpack E2E: Introduce Account Protection Tests Feb 19, 2025
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Wasn't able to figure out how to run these locally, but refer to the Jetpack post-connection E2E test logs I can all tests ran and were successful.

@nateweller nateweller force-pushed the add/account-protection-e2e branch from 187a8f6 to 84ad2e3 Compare February 20, 2025 13:50
@nateweller nateweller merged commit 908ae9a into add/account-protection Feb 20, 2025
58 of 59 checks passed
@nateweller nateweller deleted the add/account-protection-e2e branch February 20, 2025 14:08
@github-actions github-actions bot removed the [Status] Needs Team Review Your teammate needs to review this PR. label Feb 20, 2025
@zinigor zinigor added this to the jetpack/14.4 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests [Package] Account Protection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants