Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat Card: add "hideValue" property #41454

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Jan 31, 2025

Extracted from #40191

Proposed changes:

  • Adds a hideValue prop to the StatCard component, to enable intentionally displaying a "-" character instead of a zero when a stat value is unavailable.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-v1n-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Test the StatCard Storybook: cd projects/js-packages/storybook && pnpm storybook:dev

Screenshots:

Screenshot 2025-02-09 at 4 45 48 PM Screenshot 2025-02-09 at 4 46 00 PM

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Your teammate needs to review this PR. labels Jan 31, 2025
@nateweller nateweller requested a review from a team January 31, 2025 03:56
@nateweller nateweller self-assigned this Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/components/stat-card-hide-value branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/components/stat-card-hide-value
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/components/stat-card-hide-value

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@nateweller nateweller force-pushed the add/components/stat-card-hide-value branch from bd341b7 to d71d235 Compare February 9, 2025 23:50
@nateweller nateweller marked this pull request as ready for review February 9, 2025 23:50
@nateweller nateweller requested a review from dkmyta February 9, 2025 23:51
@nateweller nateweller force-pushed the add/components/stat-card-hide-value branch from d71d235 to b620061 Compare February 22, 2025 17:20
Copy link

jp-launch-control bot commented Feb 22, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components RNA [Status] Needs Team Review Your teammate needs to review this PR. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant