New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hosting Provider guess #34864

Merged

jboland88 merged 6 commits into trunk from add/my-jetpack-host-provider-check

Jan 18, 2024

Contributor

robertsreberski commented Jan 5, 2024 •

edited

Loading

Fixes https://github.com/Automattic/jetpack-roadmap/issues/1039

Proposed changes:

Add hosting provider guess using nameservers (from wpcom)
Implement the initial state value indicating whether user is guessed as coming from hosting provider or not

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Run the site on JN / Ephemeral Site
Activate Jetpack Beta plugin with this branch, and go to /wp-admin/admin.php?page=my-jetpack
Check that window.myJetpackInitialState.isUserFromHostPartner exists
(currently, there is no way to check whether hosting provider is guess properly)

github-actions bot added the [Package] My Jetpack label

Contributor

github-actions bot commented Jan 5, 2024 •

edited

Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Inspect plugin:

Next scheduled release: February 6, 2024.
Scheduled code freeze: January 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions bot added the [Status] Needs Author Reply label

robertsreberski force-pushed the add/my-jetpack-host-provider-check branch from 41da729 to 2771906 Compare

January 5, 2024 18:15

Contributor

github-actions bot commented Jan 5, 2024 •

edited

Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/my-jetpack-host-provider-check branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/my-jetpack-host-provider-check

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jboland88 requested changes

View reviewed changes

Contributor

jboland88 left a comment

Just a few small comments, I think this is a clever solution for giving a basic guess at the host 👍

projects/packages/my-jetpack/src/utils/nameservers.php Outdated Show resolved Hide resolved

projects/packages/my-jetpack/src/class-initializer.php Outdated Show resolved Hide resolved

jeherve reviewed

View reviewed changes

Member

jeherve left a comment

What would you think about moving some of this to the Status package, where we already have a Host class?

jetpack/projects/packages/status/src/class-host.php

Lines 12 to 15 in 0817af0

    
           /** 
        
            * Hosting provider class. 
        
            */ 
        
           class Host {

Contributor Author

robertsreberski commented Jan 8, 2024

What would you think about moving some of this to the Status package, where we already have a Host class?

@jeherve I think it's a good idea, I've just implemented that, let me know what you think!

github-actions bot added the [Package] Status label

jeherve reviewed

View reviewed changes

projects/packages/status/src/class-host.php Outdated

+              	 * @param string $domain The domain of the site to check.
+              	 * @return string
+              	 */
+              	private function get_nameserver_dns_records( $domain ) {

Member

jeherve Jan 8, 2024

thank you! Do you think you could add some tests for the new method, in projects/packages/status/tests/php/test-host.php?

github-actions bot added [Tests] Includes Tests [Plugin] Backup [Plugin] Boost [Plugin] Inspect [Plugin] Jetpack [Plugin] Migration [Plugin] Protect [Plugin] Search [Plugin] Social [Plugin] Starter Plugin [Plugin] VideoPress labels

robertsreberski added 6 commits

January 18, 2024 11:05


          Add basic hosting provider guess (using nameservers and legacy check)

cd16511


          changelog

bc81577


          Implement the guess as part of Status package

f69a94b


          changelog

8143ee5


          Add tests and fix issues

e4bc01a


          Update version

1b023c5

jboland88 force-pushed the add/my-jetpack-host-provider-check branch from 8403bfe to 1b023c5 Compare

January 18, 2024 16:08

jboland88 approved these changes

View reviewed changes

Contributor

jboland88 left a comment

This tested as described, the new tests are passing and the code LGTM 👍

jboland88 merged commit 462eb8c into trunk

65 of 66 checks passed

jboland88 deleted the add/my-jetpack-host-provider-check branch

January 18, 2024 16:46

github-actions bot removed the [Status] Needs Author Reply label

robertsreberski mentioned this pull request

Add site lifecycle status guess to My Jetpack #35815

Merged

3 tasks

jeherve added a commit that referenced this pull request


          My Jetpack: remove unused parameter.

f45b68c

This was added in #34864, but never actually used. We can consequently remove it.

jeherve mentioned this pull request

Performance: avoid unnecessary hosting provider detection when possible. #41890

Merged

3 tasks

jeherve added a commit that referenced this pull request


          Performance: avoid unnecessary hosting provider detection when possib…

e3ea28e

…le. (#41890)

* Status: add parameter to bring more specificity to host detection

In a lot of situations, we are not interested in knowing the exact hosting provider ; we just want to know if the site is on the WordPress.com platform (and if so, which one).

* Script data: provide less specific host info for Jetpack Social

We do not need to know exactly what host we're with. It's enough to know it's a WordPress.com platform.

See #41076 where this was set up.

* Boost: be more specific in hosting provider check.

We only need to check for specific WordPress.com platforms here (WoA or Atomic), so we can ditch the generic host detection and only look for those 2.

This was added in #39155.

* My Jetpack: remove unused parameter.

This was added in #34864, but never actually used. We can consequently remove it.

* Update Phan baseline

pablinos pushed a commit that referenced this pull request


          Performance: avoid unnecessary hosting provider detection when possib…

ab9d633

…le. (#41890)

* Status: add parameter to bring more specificity to host detection

In a lot of situations, we are not interested in knowing the exact hosting provider ; we just want to know if the site is on the WordPress.com platform (and if so, which one).

* Script data: provide less specific host info for Jetpack Social

We do not need to know exactly what host we're with. It's enough to know it's a WordPress.com platform.

See #41076 where this was set up.

* Boost: be more specific in hosting provider check.

We only need to check for specific WordPress.com platforms here (WoA or Atomic), so we can ditch the generic host detection and only look for those 2.

This was added in #39155.

* My Jetpack: remove unused parameter.

This was added in #34864, but never actually used. We can consequently remove it.

* Update Phan baseline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] My Jetpack [Package] Status [Plugin] Backup [Plugin] Boost [Plugin] Inspect [Plugin] Jetpack [Plugin] Migration [Plugin] Protect [Plugin] Search [Plugin] Social [Plugin] Starter Plugin [Plugin] VideoPress [Tests] Includes Tests