Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery Block: Add a style extension to core gallery block to allow tiling #16476

Closed
wants to merge 1 commit into from

Conversation

glendaviesnz
Copy link
Contributor

@glendaviesnz glendaviesnz commented Jul 14, 2020

This is currently just a PoC to look at options for enhancing the core block and deprecating the tiled gallery block as a way to get the captions outlined in #11794 and reduce duplication.

Changes proposed in this Pull Request:

  • Add a style option to core gallery block

Testing instructions:

  • Check out PR, add a core gallery block and select the 'Tiled' style option
  • The tiled layout has a repeating pattern after 30 images, so if you add more than 30 images you will see the full extent of the layout

tile

@glendaviesnz glendaviesnz requested a review from a team July 14, 2020 04:56
@glendaviesnz glendaviesnz self-assigned this Jul 14, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello glendaviesnz! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D46336-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16476

Generated by 🚫 dangerJS against 624257e

@glendaviesnz
Copy link
Contributor Author

FYI - currently the grid styling only works in the editor, not the front end - will sort that tomorrow

@glendaviesnz
Copy link
Contributor Author

Closing this in favour of WordPress/gutenberg#23929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants