Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Sync minor change from wp.com #16078

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

gibrown
Copy link
Member

@gibrown gibrown commented Jun 5, 2020

This change made deploying on wp.com a little easier and we already set the jetpack blog id in the parent class: https://github.com/Automattic/jetpack/blob/master/modules/search/class.jetpack-search.php#L177

To test, just try out instant search on an existing site and verify that it works

@gibrown gibrown added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Search For all things related to Search Instant Search [Status] Needs Team Review labels Jun 5, 2020
@gibrown gibrown requested a review from a team June 5, 2020 18:24
@gibrown gibrown self-assigned this Jun 5, 2020
@jetpackbot
Copy link

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16078

Generated by 🚫 dangerJS against 2b29e6a

@jeherve jeherve added this to the 8.7 milestone Jun 8, 2020
@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 8, 2020
@gibrown gibrown merged commit 4412f80 into master Jun 15, 2020
@gibrown gibrown deleted the update/search-blog-id-sync-wpcom branch June 15, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants