Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif block - add example #13610

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Gif block - add example #13610

merged 2 commits into from
Oct 2, 2019

Conversation

MichaelArestad
Copy link
Contributor

Master issue: #13510

Changes proposed in this Pull Request:

  • Added an example preview to the block in the Inspector.

Before

image

After

image

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Adding support for a new feature

Testing instructions:

  • Create a new post
  • Click the + to open the Inserter
  • Hover over Gif

Proposed changelog entry for your changes:

  • None needed

@MichaelArestad
Add Gif block example
70ca2f4 
* props @goldsounds
@MichaelArestad MichaelArestad added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] GIF labels Oct 1, 2019
@MichaelArestad MichaelArestad added this to the 7.9 milestone Oct 1, 2019
@MichaelArestad MichaelArestad requested a review from a team October 1, 2019 18:27
@MichaelArestad MichaelArestad self-assigned this Oct 1, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 1, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 45255a3

@joanrho
Copy link
Contributor

joanrho commented Oct 1, 2019

When I tested earlier today, I got this animated "OOPS" GIF which I think might be an error in loading the WP logo gif properly?

Screen Shot 2019-10-01 at 12 30 44 PM

@MichaelArestad
Copy link
Contributor Author

@joanrho fixed. It was a typo. My typo.

@joanrho
Copy link
Contributor

joanrho commented Oct 1, 2019

@MichaelArestad Thanks for the fix. I see the rotating logo now. Looks great and works as expected!

@jeherve jeherve mentioned this pull request Oct 2, 2019
Closed
15 tasks
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello MichaelArestad! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33474-code before merging this PR. Thank you!

jeherve
jeherve approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, it's simple enough. I like it! Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 2, 2019
@jeherve jeherve merged commit f98c0a4 into master Oct 2, 2019
@jeherve jeherve deleted the add/giphy-block-example branch October 2, 2019 15:56
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 2, 2019
@keoshi
Copy link
Contributor

keoshi commented Oct 2, 2019

NOICE!

simison
simison reviewed Oct 4, 2019
View reviewed changes
extensions/blocks/gif/index.js
align: 'center',
giphyUrl: 'https://giphy.com/embed/fxKWgoOG9hzPPkE1oc',
paddingTop: '100%',
searchText: __( 'WordPress', 'jetpack' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be translated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose not since it doesn't visibly show up. Will remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
[Block] GIF [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
7 participants
@MichaelArestad @jetpackbot @joanrho @matticbot @keoshi @simison @jeherve