Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Business Hours block - add example #13609

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Business Hours block - add example #13609

merged 1 commit into from
Oct 2, 2019

Conversation

MichaelArestad
Copy link
Contributor

Master issue: #13510

Changes proposed in this Pull Request:

  • Added an example preview to the block in the Inspector.

Before

image

After

image

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Adding support for a new feature

Testing instructions:

  • Create a new post
  • Click the + to open the Inserter
  • Hover over Business Hours

Proposed changelog entry for your changes:

  • None needed

@MichaelArestad
Add business hours example
832ebaf 
* props @gravityrail for literally all the work
@MichaelArestad MichaelArestad added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Business Hours labels Oct 1, 2019
@MichaelArestad MichaelArestad requested a review from a team October 1, 2019 18:13
@MichaelArestad MichaelArestad self-assigned this Oct 1, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello MichaelArestad! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33409-code before merging this PR. Thank you!

@MichaelArestad MichaelArestad added this to the 7.9 milestone Oct 1, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 832ebaf

@jeherve jeherve mentioned this pull request Oct 2, 2019
Closed
15 tasks
jeherve
jeherve approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for me, although the text is quite small:

image

Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 2, 2019
@jeherve jeherve merged commit 081dba3 into master Oct 2, 2019
@jeherve jeherve deleted the add/busines-hours-block-example branch October 2, 2019 15:47
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
[Block] Business Hours [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelArestad @matticbot @jetpackbot @jeherve