Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled Gallery Block - added example #13580

Merged
merged 6 commits into from
Oct 3, 2019
Merged

Tiled Gallery Block - added example #13580

merged 6 commits into from
Oct 3, 2019

Conversation

MichaelArestad
Copy link
Contributor

@MichaelArestad MichaelArestad commented Sep 27, 2019 •
edited
Loading

Master issue: #13510

Changes proposed in this Pull Request:

  • Added example to the Tiled Gallery block

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Before

image

After

image

Testing instructions:

  • Create a new post
  • Click the + to insert a new block
  • Hover over Tiled Gallery

Proposed changelog entry for your changes:

  • None here

@MichaelArestad MichaelArestad requested a review from a team September 27, 2019 22:05
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello MichaelArestad! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33293-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 27, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 4cecd5c

@joanrho
Copy link
Contributor

joanrho commented Sep 28, 2019 •
edited
Loading

Edit: Updated before/after screenshot of the preview mock and added direct links to the stock images used from Pixabay and Unsplash (No attribution required. See licenses here: Pixabay license / Unsplash license)

Before/After:
Screen Shot 2019-09-30 at 4 07 16 PM

Images Used:

@jeherve jeherve added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label Sep 30, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 30, 2019
@jeherve jeherve mentioned this pull request Sep 30, 2019
Closed
15 tasks
@MichaelArestad
Tiled Gallery Block - added images
3473c3d 
* does not work
* will resize images before we merge to master
@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33293-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33293-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33293-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33293-code has been updated.

@matticbot
Copy link
Contributor

MichaelArestad, Your synced wpcom patch D33293-code has been updated.

@MichaelArestad MichaelArestad added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Oct 1, 2019
jeherve
jeherve approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 3, 2019
@jeherve jeherve merged commit 2e9ac07 into master Oct 3, 2019
@jeherve jeherve deleted the update/tiled-gallery-block branch October 3, 2019 12:05
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@joanrho joanrho

@MichaelArestad MichaelArestad

Labels
[Block] Tiled Gallery [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
6 participants
@MichaelArestad @matticbot @jetpackbot @joanrho @jeherve @gravityrail