Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block previews to Gutenberg blocks #13565

Closed
wants to merge 12 commits into from
Closed

Add block previews to Gutenberg blocks #13565

wants to merge 12 commits into from

Conversation

gravityrail
Copy link
Contributor

@gravityrail gravityrail commented Sep 27, 2019 •
edited by jeherve
Loading

Master issue: #13510

Done:

  • Business Hours
  • Contact Form
  • Contact Info
  • Gif

Done but Needs design:

  • Slideshow needs hosted images for previews
  • Tiled gallery needs hosted images for previews
  • Markdown example content
  • Related posts - I only show the "not enough content" preview. Maybe we should use an image?
  • Repeat visitor - This wraps a nested block, mine doesn't have a nested block in the example. Not familiar with the official Gutenberg way to do this

Skipped:

  • Mailchimp, because it has complicated state that depends on API calls (can be done, but complex) (render with image?)
  • Map, because it requires an API key (render with image?)
  • Publicize, requires connections (render with image?)
  • Recurring payments (complex)
  • Simple payments (complex)
  • Publicize, doesn't appear to be registered
  • SEO, couldn't get it to show up
  • Likes, ditto
  • Sharing, ditto
  • Shortlinks, ditto
  • Subscriptions, ditto
  • VideoPress, ditto

@gravityrail gravityrail requested a review from a team September 27, 2019 15:42
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gravityrail! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33280-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 27, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 7876a21

@matticbot
Copy link
Contributor

gravityrail, Your synced wpcom patch D33280-code has been updated.

@matticbot
Copy link
Contributor

gravityrail, Your synced wpcom patch D33280-code has been updated.

simison
simison reviewed Sep 27, 2019
View reviewed changes
extensions/blocks/contact-form/index.js Outdated
has_form_settings_set: null,
subject: 'My New Site',
submitButtonText: 'Submit',
submit_button_text: 'Submit',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject and submit button texts would need to be wrapped in __()

@simison
Copy link
Member

simison commented Sep 27, 2019 •
edited
Loading

Likes, because it doesn't appear to be registered

It's a sidebar extension, so it won't appear in the block picker. Same is true for publicize and "sharing". There's a setting somewhere in Jetpack dash to enable those.

Nice to see this coming along!

@mtias
Copy link
Member

mtias commented Sep 27, 2019

Mailchimp, because it has complicated state that depends on API calls (can be done, but complex) (render with image?)

In some of these cases it might be alright to show the placeholder state if it's well designed.

@MichaelArestad
Copy link
Contributor

I would like to remove Tiled Galleries and Slideshow from this PR. What's the most straightforward method of doing that?

@jeherve jeherve added this to the 7.9 milestone Sep 30, 2019
@jeherve jeherve mentioned this pull request Sep 30, 2019
Closed
15 tasks
@jeherve
Copy link
Member

jeherve commented Sep 30, 2019 •
edited
Loading

I would like to remove Tiled Galleries and Slideshow from this PR. What's the most straightforward method of doing that?

@MichaelArestad I see you have created standalone PRs for 2 blocks already. I think it would be okay to keep doing that, and create one PR for each block. Once we have one PR per block, we can abandon this PR.

@jeherve jeherve added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label Sep 30, 2019
@MichaelArestad
Copy link
Contributor

@jeherve sounds good.

@gravityrail gravityrail closed this Oct 3, 2019
@gravityrail gravityrail reopened this Oct 3, 2019
@MichaelArestad
Copy link
Contributor

All of these are in!

@scruffian scruffian deleted the add/gutenberg-block-previews branch October 14, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees

@MichaelArestad MichaelArestad

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Design Touches WP.com Files
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
8 participants
@gravityrail @matticbot @jetpackbot @simison @mtias @MichaelArestad @jeherve @kraftbj