Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jetpack live branches #11823

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix Jetpack live branches #11823

merged 1 commit into from
Apr 3, 2019

Conversation

simison
Copy link
Member

@simison simison commented Apr 3, 2019 •
edited
Loading

Changes proposed in this Pull Request:

Before

Live branch URLs didn't have the debug feature on initial load
Screenshot 2019-04-03 at 11 16 08

After

Screenshot 2019-04-03 at 11 14 21

Additional new features

Don't offer live branches for Draft PRs:
Screenshot 2019-04-03 at 11 12 25

Allow opening sites from master for merged branches:
Screenshot 2019-04-03 at 11 20 02

Testing instructions:

  • Test with Open, Merged and Draft PRs.

@simison
Fix Jetpack live branches
bcf10ad 
- Don't offer live branches for Draft PRs
- Allow spinning up a site from `master` branch for merged branches
- Fix issue of not picking initially selected values from the list in the URL
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial [Pri] Low labels Apr 3, 2019
@simison simison requested a review from a team April 3, 2019 08:25
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against bcf10ad

@simison simison added the [Status] Needs Review This PR is ready for review. label Apr 3, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 3, 2019
jeherve
jeherve approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well. 🚢

@simison simison merged commit 93cfaa6 into master Apr 3, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 3, 2019
@simison simison deleted the update/fix-jetpack-live-branches branch April 3, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simison @jetpackbot @jeherve @brbrr @matticbot