Add optimistic update revert, remove async from sync function (#41878)

Automattic · Feb 20, 2025 · 271839a · 271839a
1 parent bd7bd61
commit 271839a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...s/protect/src/js/data/account-protection/use-toggle-account-protection-module-mutation.ts b/...s/protect/src/js/data/account-protection/use-toggle-account-protection-module-mutation.ts
@@ -16,7 +16,7 @@ export default function useToggleAccountProtectionMutation(): UseMutationResult
 
 	return useMutation( {
 		mutationFn: API.toggleAccountProtection,
-		onMutate: async () => {
+		onMutate: () => {
 			showSavingNotice();
 
 			// Get the current cached data
@@ -37,7 +37,15 @@ export default function useToggleAccountProtectionMutation(): UseMutationResult
 		onSuccess: () => {
 			showSuccessNotice( __( 'Changes saved.', 'jetpack-protect' ) );
 		},
-		onError: () => {
+		onError: ( error, variables, context ) => {
+			// If the request failed, revert the optimistic update.
+			if ( context?.previousData ) {
+				queryClient.setQueryData< AccountProtectionStatus >(
+					[ QUERY_ACCOUNT_PROTECTION_KEY ],
+					context.previousData
+				);
+			}
+
 			showErrorNotice( __( 'An error occurred.', 'jetpack-protect' ) );
 		},
 		onSettled: () => {