Remove pre_handle_404 filter

[maximomartinezsoria]

Problem: non-existent paged author archives are not throwing a 404. For example: /author/slug/page/100000. Will load and be indexed by crawlers.

Others are having this problem too: #703

[leogermani]

This would add a regression. See #425 and 09a1c50

So what we need is:

We need to ensure the same behavior for regular users and Guest authors.

• When you visit the authors's page, never return 404, even if the author or guest author do not have any posts yet
• When you visit the author's page with paged in a range outside the range, return 404

I did a quick test here and if I think it's just a matter of surrounding that filter in a is_paged() check:

if ( ! is_paged() ) {
	add_filter( 'pre_handle_404', '__return_true' );
}

Bonus points if you are able to update the tests on test-author-queried-object.php to check for all these cases

[maximomartinezsoria]

Thanks for your answer!

Gusts authors behavior matching core behavior is already tested so I just added a new test for pagination.

[leogermani]

LGTM! Thanks!