Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with cache key id not being deleted. #832

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Issue with cache key id not being deleted. #832

merged 2 commits into from
Dec 6, 2021

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Dec 2, 2021

get_guest_author_by method in CoAuthors_Guest_Authors allows the key id. It caches the result using the key as park of the cache key. The only problem is that the delete_guest_author_cache method does not recognize id as a valid key, so that cache remains indefinitely. This PR fixes the issue with id cache not being deleted.

rebeccahum
rebeccahum approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@rebeccahum rebeccahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rebeccahum rebeccahum merged commit b8286ae into Automattic:master Dec 6, 2021
@rebeccahum rebeccahum modified the milestones: 3.4.9, 3.5 Dec 6, 2021
@mauteri mauteri deleted the feature/cache-key-id-issue branch December 6, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccahum rebeccahum rebeccahum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mauteri @rebeccahum