-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar Plugin for Block Editor Integration #790
Conversation
Hi @lschuyler – I updated the PR with the following changes and updated the PR comment for the steps to test the feature accordingly:
Happy to address anything else you see. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @laras126. The tests are all passing for me now too.
Thanks for all your work here!
We'll get this merged and released.
co-authors-plus.php
Outdated
* Block editor functionality in the sidebar is | ||
* disabled by default. | ||
*/ | ||
const SIDEBAR_PLUGIN_ENABLED = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is outdated! Good catch – I'll update it momentarily.
Thank you so much for your work on this, @laras126! I've added just two minor comments and then we should be good to go. |
Remove the `/wp/v2/coauthors` endpoint added in #790 that is not being used.
@lschuyler @rebeccahum @laras126 Was there any consideration of the escaping that seems to be done here? How could the REST Response know what context the escaping would need to be done with? (Possibly causing #937) |
Overview
This PR includes the addition of a panel in the Document sidebar in Gutenberg that provides the Co-Authors Plus functionality. There are a few things still to do, but I wanted to open this up now to start getting feedback.
Combobox
block editor component for the UI, including the autocompleteScreenshots
Video of adding, removing, and re-ordering Co-Authors using the Sidebar panel.
coauthors-sidebar-plugin.mp4
How to Test This PR