use the PXR_NS macro instead of pxr in the layer editor #998
Conversation
The macro should be used rather than hard-coding "pxr" as the namespace in case the core USD build is configured to use a different namespace (or no namespace).
| void | ||
| updateFromSessionState(PXR_NS::UsdStageRefPtr const& stageToSelect = PXR_NS::UsdStageRefPtr()); |
There was a problem hiding this comment.
An unfortunate choice made by clang-format here. :(
There was a problem hiding this comment.
We keep track of issues like this. If you have to know the configuration that would prevent this, please send it my way and I will put it in our internal wiki. Once we will be considering adopting clang-format v11, we will revisit configuration settings to consider tweaks for annoying parts people are finding.
There was a problem hiding this comment.
Thanks @kxl-adsk! Looking at the current set of options, I think it might be IndentWrappedFunctionNames: 'false'? I haven't had a chance to build a newer version of clang-format to try it out though. Looks like it was known as IndentFunctionDeclarationAfterType for a while too: llvm/llvm-project@c75e1ef
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/replace_pxr_namespace_with_PXR_NS_in_layerEditor
branch
Just a small follow-up from the merge of the layer editor work from #988:
The
PXR_NSmacro should be used rather than hard-codingpxras the namespace when referring to symbols in USD in case the core USD build is configured to use a different namespace (or in our case, no namespace withPXR_USE_NAMESPACES=0).