Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-107449 Layer disappears when moved under last layer. #994

Merged

Conversation

spinell-adsk
Copy link
Contributor

When a layer in the Layer Editor is moved (drag & drop) under the last layer in a hierarchy it will disappear.

drag & drop a layer is a two steps operation.
1- Removed the layer from it's original index position
2- Adding the layer to is new index location.

The problem is we can't add a layer at the end of the layer list because of a wrong comparaison.
So, the layer is removed but never added at the new location.

Copy link
Contributor

@fowlertADSK fowlertADSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

- Rework original fix to avoid crash on lnux/osx when removing a layer with out of bound index
@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 22, 2020
@kxl-adsk kxl-adsk merged commit f42e692 into dev Dec 23, 2020
@kxl-adsk kxl-adsk deleted the spinell/MAYA-107449/layer_disappears_when_moved_under_last_layer branch December 23, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants