Proxy Shape AE Template - Part 2 #944

seando-adsk · 2020-11-26T18:52:57Z

JIRA items:

MAYA-107386 As a user, on the stage AE template I'd like to connect to time
MAYA-107350 As a user, on the stage AE template I'd like to see what my default prim is
MAYA-107338 As a user, on the stage AE template I'd like to see what my Root Layer is
MAYA-107273 As a user, on the stage AE template I'd like to toggle Purpose=Default

Create new AETemplatesHelpers.py file which is used by the MEL templates to query USD (thru python API).
Organized proxy shape template in sections: "Stage", "Stage Source" and "Stage Display".
Suppressed 'Stage Cache ID' and 'Out Stage Cache ID'.
Added new non-editable text fields (for display purposes only) for "Root Layer" and "Default Prim".
Added tooltips to some controls.

…o time MAYA-107350 As a user, on the stage AE template I'd like to see what my default prim is MAYA-107338 As a user, on the stage AE template I'd like to see what my Root Layer is MAYA-107273 As a user, on the stage AE template I'd like to toggle Purpose=Default * Create new AETemplatesHelpers.py file which is used by the MEL templates to query USD (thru python API). * Organized proxy shape template in sections: "Stage", "Stage Source" and "Stage Display". * Suppressed 'Stage Cache ID' and 'Out Stage Cache ID'. * Added new non-editable text fields (for display purposes only) for "Root Layer" and "Default Prim". * Added tooltips to some controls.

seando-adsk · 2020-11-26T18:54:00Z

plugin/adsk/scripts/AETemplateHelpers.py

+                return rootLayer.GetDisplayName() if rootLayer.anonymous else rootLayer.realPath
+    except:
+        pass
+    return ''


I created this python file to contains AE template helpers that I call from the actual MEL template.

seando-adsk · 2020-11-26T18:55:08Z

plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

+            // We aren't displaying the "inStageData" attribute in the ProxyShapeInfo. We simply
+            // pass it in order to get the current nodename. Cannot use the input one here as it
+            // changes based on which proxy shape the AE is viewing.
+            editorTemplate -callCustom "AEmayaUsdProxyShapeInfoNew" "AEmayaUsdProxyShapeInfoReplace" inStageData;


This adds the "Root Layer" and "Default Prim" (non-editable) fields. These aren't actual attributes on the proxy shape. The fields are for display purposes only.

seando-adsk · 2020-11-26T18:55:57Z

plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

+    textFieldGrp -edit -text $rootLayer mayaUsdProxyShapeRootLayer;
+    textFieldGrp -edit -text $defaultPrim mayaUsdProxyShapeDefaultPrim;


This will update the two fields with the values from the current proxy shape being shown.

seando-adsk · 2020-11-26T18:56:21Z

plugin/adsk/scripts/AEmayaUsdProxyShapeTemplate.mel

+    textFieldGrp -label "Root Layer" -editable 0
+                 -ann "Identifies the root layer of a stage. If a file path is shown in this field, the root layer is a file on disk. If a layerName is shown in this field, the root layer is an anonymous layer."
+                 mayaUsdProxyShapeRootLayer;
+
+    textFieldGrp -label "Default Prim" -editable 0
+                 -ann "As part of its metadata, each stage can identify a default prim. This is the primitive that is referenced in if you reference in a file."
+                 mayaUsdProxyShapeDefaultPrim;


Create two text fields for displaying info.

seando-adsk

Proxy shape AE template organization.

ppt-adsk · 2020-11-26T20:23:49Z

plugin/adsk/scripts/AETemplateHelpers.py

+
+def GetDefaultPrimName(proxyShape):
+    if not proxyShape.startswith('|world'):
+        proxyShape = '|world' + proxyShape


We should not do this. We should fix the implementation of getStage() in wrapUtils.cpp so that it converts the argument path string to a path using Ufe::PathString::path().

As we discussed I cleaned up all the usage of "|world"

ppt-adsk · 2020-11-26T20:24:17Z

plugin/adsk/scripts/AETemplateHelpers.py

+
+def GetRootLayerName(proxyShape):
+    if not proxyShape.startswith('|world'):
+        proxyShape = '|world' + proxyShape


Same as above: let's fix the wrapper instead of working around it.

…o time MAYA-107350 As a user, on the stage AE template I'd like to see what my default prim is MAYA-107338 As a user, on the stage AE template I'd like to see what my Root Layer is MAYA-107273 As a user, on the stage AE template I'd like to toggle Purpose=Default * Code review comment - cleanup usage of "|world"

seando-adsk · 2020-11-27T16:00:08Z

plugin/al/lib/AL_USDMaya/AL/usdmaya/nodes/ProxyShape.cpp

-    return Ufe::PathSegment(fullpath.asChar(), MAYA_UFE_RUNTIME_ID, MAYA_UFE_SEPARATOR);
-}
-
-Ufe::Path ProxyShape::ufePath() const { return Ufe::Path(ProxyShape::ufePathSegment()); }


This exact method already exists in the base class (which I fixed for the |world). The ufePathSegment() method above is not needed as you can get that from this ufePath() method.

…o time MAYA-107350 As a user, on the stage AE template I'd like to see what my default prim is MAYA-107338 As a user, on the stage AE template I'd like to see what my Root Layer is MAYA-107273 As a user, on the stage AE template I'd like to toggle Purpose=Default * Bullet-proof some code that can have null path.

seando-adsk · 2020-11-27T16:31:10Z

lib/mayaUsd/ufe/StagesSubject.cpp

@@ -316,8 +316,13 @@ void StagesSubject::onStageInvalidate(const MayaUsdProxyStageInvalidateNotice& n
    afterOpen();

 #ifdef UFE_V2_FEATURES_AVAILABLE
-    Ufe::SceneItem::Ptr sceneItem = Ufe::Hierarchy::createItem(notice.GetProxyShape().ufePath());
-    Ufe::Scene::instance().notify(Ufe::SubtreeInvalidate(sceneItem));
+    auto p = notice.GetProxyShape().ufePath();


It is possible for this path to return empty when called before the proxy shape is ready. The MDagPath in the proxy shape is empty. The previous code (before my world cleanup) would thus return a Ufe::path to "|world" which was incorrect.

ppt-adsk

Thanks for the cleanup!

fowlertADSK

LGTM

seando-adsk requested review from fowlertADSK and ppt-adsk November 26, 2020 18:53

seando-adsk commented Nov 26, 2020

View reviewed changes

ppt-adsk requested changes Nov 26, 2020

View reviewed changes

kxl-adsk added proxy Related to base proxy shape workflows Related to in-context workflows labels Nov 26, 2020

seando-adsk added 2 commits November 27, 2020 10:53

Fixed weird ' character

515cca5

seando-adsk commented Nov 27, 2020

View reviewed changes

seando-adsk requested a review from ppt-adsk November 27, 2020 16:31

ppt-adsk approved these changes Nov 27, 2020

View reviewed changes

seando-adsk assigned ecp-maya-devops-adsk Nov 27, 2020

fowlertADSK approved these changes Nov 30, 2020

View reviewed changes

seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 30, 2020

seando-adsk unassigned ecp-maya-devops-adsk Nov 30, 2020

kxl-adsk merged commit 192ef72 into dev Nov 30, 2020

kxl-adsk deleted the donnels/proxy_shape_ae_template_part_2 branch November 30, 2020 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proxy Shape AE Template - Part 2 #944

Proxy Shape AE Template - Part 2 #944

seando-adsk commented Nov 26, 2020

seando-adsk Nov 26, 2020

seando-adsk Nov 26, 2020

seando-adsk Nov 26, 2020

seando-adsk Nov 26, 2020

seando-adsk left a comment

ppt-adsk Nov 26, 2020

seando-adsk Nov 27, 2020

ppt-adsk Nov 26, 2020

seando-adsk Nov 27, 2020

seando-adsk Nov 27, 2020

ppt-adsk left a comment

fowlertADSK left a comment

		textFieldGrp -edit -text $rootLayer mayaUsdProxyShapeRootLayer;
		textFieldGrp -edit -text $defaultPrim mayaUsdProxyShapeDefaultPrim;

Proxy Shape AE Template - Part 2 #944

Proxy Shape AE Template - Part 2 #944

Conversation

seando-adsk commented Nov 26, 2020

JIRA items:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seando-adsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppt-adsk left a comment

Choose a reason for hiding this comment

fowlertADSK left a comment

Choose a reason for hiding this comment