Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-107484 - Time is not connected when creating a new empty USD stage #928

Merged
merged 4 commits into from
Nov 23, 2020

Conversation

seando-adsk
Copy link
Collaborator

MAYA-107484 - Time is not connected when creating a new empty USD stage

  • Connected time to proxy shape node

@seando-adsk seando-adsk added the adsk Related to Autodesk plugin label Nov 18, 2020
Copy link
Contributor

@HamedSabri-adsk HamedSabri-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Collaborator Author

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new test for the create stages commands. I test that the proxy node was created, selected and that the time is connected.

Comment on lines +197 to +199
global proc mayaUsd_createStageFromFilePath(string $usdFile)
{
doCreateStage($usdFile);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple global proc that allows me to do the same as proc above, but sending in a file path, skipping the file dialog.

Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @seando-adsk, for adding the test.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 23, 2020
@kxl-adsk kxl-adsk merged commit 5fd9046 into dev Nov 23, 2020
@kxl-adsk kxl-adsk deleted the donnels/MAYA-107484/connect_time_to_new_empty_usd_stage branch November 23, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants