Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for building with latest post-20.11 dev branch of core USD #889

Merged
merged 6 commits into from
Nov 5, 2020

Conversation

mattyjams
Copy link
Contributor

This PR includes a bunch of changes that go along with commits recently pushed to the dev branch of core USD. All supported releases of USD are still supported with these changes. The build.md was updated to reflect support up to the current dev branch commit.

@kxl-adsk kxl-adsk requested a review from huidong-chen November 4, 2020 22:29
@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Nov 5, 2020
…elegateCtx::InsertRprim()

HdRenderIndex::InsertInstancer() itself calls this, so there is no reason to do
so again. It has been that way since at least as far back as core USD 19.11, so
no USD API version guards are necessary.

Starting after core USD 20.11, the signature of InstancerInserted() was changed
to include the HdDirtyBits.

This change corresponds to core USD commit
PixarAnimationStudios/OpenUSD@5a73314

(Internal change: 2118195)
…tTokens

This is some prep work for an upcoming UsdLux attribute names update.

This change corresponds to core USD commit
PixarAnimationStudios/OpenUSD@92e25a5

(Internal changes: 2119872, 2119882)
…ter when creating/inserting rprims

This change corresponds to core USD commit
PixarAnimationStudios/OpenUSD@6772ff6

(Internal change: 2120135)
This change corresponds to core USD commit
PixarAnimationStudios/OpenUSD@b5d3809

(Internal change: 2120668)
UsdShadeConnectableAPI now has a concept of containers, and with that the
existing IsShader() and IsNodeGraph() methods were deprecated.

This change corresponds to core USD commit
PixarAnimationStudios/OpenUSD@abda3f0

(Internal changes: 2123154, 2123308)
This identifies core USD commit f7b5f25 (post 20.11 release) as the most recent
supported version of USD:

PixarAnimationStudios/OpenUSD@f7b5f25
@mattyjams mattyjams force-pushed the pr/update_to_current_core_USD_dev branch from b201bc5 to ae0eda4 Compare November 5, 2020 02:15
@mattyjams
Copy link
Contributor Author

Rebased to absorb clang-format changes from #890, and re-ran clang-format v10.0.0 on the modified files.

@@ -65,7 +65,11 @@ class HdMayaAiSkyDomeLightAdapter : public HdMayaLightAdapter
return VtValue(light.findPlug("aiExposure", true).asFloat());
} else if (paramName == HdLightTokens->normalize) {
return VtValue(light.findPlug("aiNormalize", true).asBool());
#if USD_VERSION_NUM >= 2102

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own education, when should we use USD_VERSION_NUM and when should we use HD_API_VERSION?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, this is admittedly not very obvious.

Internally, our development cadence runs faster than the public USD release cycle, and the Hydra API in particular is changing fairly rapidly. We've been needing more fine-grained API guards to deal with that as we attempt to support several releases and mixed-component builds (internal-only stuff built on top of USD) across multiple shows. There isn't really a rigid structure around when API-level guards (HD_API_VERSION, USD_IMAGING_API_VERSION, etc.) get added or incremented. It's just done as needed to address a particular API change.

So externally to Pixar, the go-to should generally be USD_VERSION_NUM, since we don't really intend to support individual components of the public USD distribution being built separately from each other.

Copy link

@huidong-chen huidong-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 5, 2020
@kxl-adsk kxl-adsk merged commit 8b3da3c into Autodesk:dev Nov 5, 2020
@mattyjams mattyjams deleted the pr/update_to_current_core_USD_dev branch November 5, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants