MAYA-107087: Don't allow parenting to a Gprim. #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamedSabri-adsk
commented
Oct 20, 2020
| childPrim.GetName().GetString().c_str(), | ||
| parentPrim.GetName().GetString().c_str()); | ||
| throw std::runtime_error(err.c_str()); | ||
| } |
There was a problem hiding this comment.
We throw an error if one tries to parent a Gprim under another.
HamedSabri-adsk
commented
Oct 20, 2020
| with self.assertRaises(RuntimeError): | ||
| cmds.parent("|Tree_usd|Tree_usdShape,/TreeBase/trunk", | ||
| "|Tree_usd|Tree_usdShape,/TreeBase/leavesXform/leaves") | ||
|
|
There was a problem hiding this comment.
Added a unit test to back the Gprim parenting restriction.
There was a problem hiding this comment.
@ppt-adsk To make testParentRelative, testParentAbsolute working under the new rule, I created a top level Xforms for cube, cylinder, sphere in "simpleSceneTRS.usda" and made sure the Translate/Rotate/Scale and Order Ops matches the underlying meshes. Github won't show the diff results. You need to use your diff-editor locally to see the changes.
HamedSabri-adsk
added
ufe-usd
ppt-adsk
approved these changes
Oct 20, 2020
HamedSabri-adsk
commented
Oct 21, 2020
| usdPaths.append(ufe.Path( | ||
| [shapeSegment, usdUtils.createUfePathSegment(n)])) | ||
| mayaPaths = [] | ||
| for n in ["|world|" + o for o in names]: | ||
| for n in ["|world|" + o for o in mayaNames]: | ||
| mayaPaths.append(ufe.Path(mayaUtils.createUfePathSegment(n))) |
There was a problem hiding this comment.
@ppt-adsk Adopt to the recent changes in simpleSceneTRS: Separated "maya" and "ufe" names list.
ppt-adsk
approved these changes
Oct 21, 2020
kxl-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
sabrih/MAYA-107087/block_parenting_gprim_to_gprim
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to block the parenting of one gprim to another. Pixar lists this behavior as "strongly discouraged", but we are also seeing evidence that this behavior is not even fully supported through hydra.
#708 (comment)