add validation of exported USD in testUsdExportSkeleton for case without bind pose #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
approved these changes
Oct 16, 2020
kxl-adsk
added
ready-for-merge
mattyjams
deleted the
pr/add_assertions_for_testUsdExportSkeleton_UsdExportSkeletonWithoutBindPose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #831, this adds validation in
testUsdExportSkeletonfor what was previously being handled by a file-based diff in an internal test we've been running. This ensures that the details specific toUsdSkelexport are as expected and that differences in unrelated scene description such asdisplayColorand materials do not cause test failures. With these changes, the baseline USD file can be removed.