-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UFE contextOps for working set management (loading and unloading) #823
add UFE contextOps for working set management (loading and unloading) #823
Conversation
This adds contextOps items for "Load", "Load with Descendants", and "Unload" based on the load set of the prim's stage, the loadable paths at or below that prim's path, and whether the prim has a payload. These items map to undoable commands that call UsdStage::Load() (with the appropriate UsdLoadPolicy) or UsdStage::Unload() with the prim's path. See the "Working Set Management" section of the USD docs on UsdStage for more discussion of load and unload rules: https://graphics.pixar.com/usd/docs/api/class_usd_stage.html
This will enable testing of the working set management UFE contextOps ("Load", "Load with Descendants", and "Unload"). Note that the Ball asset's shading variants have been lofted to the near side of the payload so that they can be queried for and selections can be made without having to load the payload.
This is great to see. Could you attach an image showing how this appears in the context menu. This is specific to payload loading only correct? |
Looking at the load/Unload rules in the docs, I'm curious how you are handling the following two rules.
Also, do you present "unload" and "load with descendants" items on the proxyShape right-click as well to apply to all root level prims? |
Yes, those cases are handled. We don't present any context items for inactive prims or prims within a prototype. The code for that is here:
I did not add context items for the proxy shape itself, since that functionality was already provided by the "Load Payloads" attribute on the proxy shape. When you make it back up to the proxy shape, you're back in Maya data model land, so there's a lot of Maya-side stuff in the right-click context menu. I didn't want to clutter that up further with "Load with Descendants" and "Unload". |
Hey Matt, this looks wonderful, will have a look at it ASAP. However, the next Maya Preview Release code complete deadline is breathing down my neck, and we have Canadian Thanksgiving on Monday, so I might not be as responsive as I'd like to be. Hope that's O.K. |
@ppt-adsk: No problem, thanks for the heads up! There's no rush with this one. Enjoy the holiday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review the code, but I did review the imagery submitted along with our design team. Looks good from a UI and workflow perspective. I'll leave it to Pierre to do the code-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code changes and everything looks good. The new test cases are great. Thanks.
This adds contextOps items for "Load", "Load with Descendants", and "Unload" based on the load set of the prim's stage, the loadable paths at or below that prim's path, and whether the prim has a payload.
These items map to undoable commands that call
UsdStage::Load()
(with the appropriateUsdLoadPolicy
) orUsdStage::Unload()
with the prim's path.See the "Working Set Management" section of the USD docs on
UsdStage
for more discussion of load and unload rules:https://graphics.pixar.com/usd/docs/api/class_usd_stage.html