MAYA-107249 When excluded prims changes we don't know if some prims were removed #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from it and so we don't know to bring them back. The easy solution is to reset everything when excluded prims changes, that gives us the correct result slowly. We don't have any workflows built on top of this right now so leaving the performance issue in the backlog.
williamkrick
commented
Oct 7, 2020
| MProfilingScope subProfilingScope(HdVP2RenderDelegate::sProfilerCategory, | ||
| MProfiler::kColorD_L1, "Populate"); | ||
|
|
||
| // It might have been already populated, clear it if so. | ||
| // Remove any excluded prims before populating |
There was a problem hiding this comment.
I considered moving this code out of _Populate as well, because it is modifying the render index rather than populating, but I didn't have a strong enough reason to do it so I left it for now.
kxl-adsk
approved these changes
Oct 7, 2020
kxl-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
krickw/MAYA-107249/rebuild_render_index_when_excluded_prims_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from it and so we don't know to bring them back. The easy solution is to reset everything when excluded prims changes, that gives us the correct result slowly. We don't have any workflows built on top of this right now so leaving the performance issue in the backlog.
In addition to fixing the defect I also cleaned up how we understand changes to the proxy shape in the render delegate. I've tried to concentrate all the checks for invalid data into a new function _ClearInvalidData. Then the rest of the code after that (_InitRenderDelegate, _Populate, etc) doesn't directly check the _proxyShapeData for changes. Instead it looks at the data it is supposed to generate and does work based on that (similar to how it works on the first frame when we create the proxyRenderDelegate). I think that will help keep the logic controlling what actually happens when proxy shape attributes change simpler.