handle namespace migration of QStringListModel between Maya 2019 and Maya 2020 in userExportedAttributesUI #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maya 2016 and earlier used PySide, while 2017 and later use PySide2.
…Maya 2020 Maya 2020 and later use Qt/PySide2 5.12.5, where QStringListModel is exported to Python with QtCore, which is also where it lives in C++. Maya 2019 and earlier use Qt 5.6.1 and PySide2 2.0.0-alpha, where QStringListModel was incorrectly exported with QtGui. See this bug for more detail: https://bugreports.qt.io/browse/PYSIDE-614
kxl-adsk
added
the
ready-for-merge
mattyjams
deleted the
pr/fix_QStringListModel_in_userExportedAttributesUI
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maya 2020 and later use Qt/PySide2 5.12.5, where
QStringListModelis exported to Python with QtCore, which is also where it lives in C++. Maya 2019 and earlier use Qt 5.6.1 and PySide2 2.0.0-alpha, whereQStringListModelwas incorrectly exported with QtGui.See this bug for more detail:
https://bugreports.qt.io/browse/PYSIDE-614
This change addresses #366. I also took this opportunity to remove support for Maya 2016 and earlier.