Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary fixes required before we can apply clang format #807

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

kxl-adsk
Copy link

@kxl-adsk kxl-adsk commented Oct 1, 2020

Draft #690 applied clang-format for the entire repository. What we found out was that we no longer can build maya-usd. This PR makes necessary fixes to address it.

@kxl-adsk kxl-adsk requested review from pmolodo and mattyjams October 1, 2020 01:08
@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Oct 1, 2020
Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @kxl-adsk!

Copy link
Contributor

@pmolodo pmolodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 2, 2020
@kxl-adsk kxl-adsk merged commit 2135906 into dev Oct 2, 2020
@kxl-adsk kxl-adsk deleted the kxl-adsk/fixes_for_clang_format branch October 2, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants